Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torchlib] Add torchlib operator for glu #1695

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Conversation

shubhambhokare1
Copy link
Contributor

@shubhambhokare1 shubhambhokare1 commented Jun 21, 2024

Fix #1665

@shubhambhokare1 shubhambhokare1 self-assigned this Jun 21, 2024
@shubhambhokare1 shubhambhokare1 added the topic: torch_lib Related to the torch/aten function lib in development label Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.29%. Comparing base (be00339) to head (cc3c6fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   76.29%   76.29%           
=======================================
  Files         240      240           
  Lines       25496    25499    +3     
  Branches     4550     4551    +1     
=======================================
+ Hits        19451    19455    +4     
+ Misses       5158     5157    -1     
  Partials      887      887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Collaborator

The tests are blocked by #1642

Copy link

github-actions bot commented Jun 22, 2024

Test Results

     30 files  ±  0      30 suites  ±0   3h 1m 15s ⏱️ - 1m 3s
  9 044 tests +  7   7 073 ✅ + 17    1 904 💤 ±0  66 ❌  - 11  1 🔥 +1 
442 039 runs  +141  97 816 ✅ +154  344 155 💤 ±0  67 ❌  - 14  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit cc3c6fe. ± Comparison against base commit be00339.

This pull request removes 86 and adds 93 tests. Note that renamed tests count towards both.
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_309_aten_linear
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_310_aten_linear_bias
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_311_aten_max_pool1d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_312_aten_max_pool1d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_313_aten_max_pool2d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_314_aten_max_pool2d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_315_aten_max_pool3d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_316_aten_max_pool3d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_317_aten_scaled_dot_product_attention
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_318_aten__scaled_dot_product_flash_attention
…
onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test.TestDeduceTypeConstraints ‑ test_deduce_type_constraints_does_not_crash_for_onnx_function_aten_glu
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_309_aten_glu
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_310_aten_linear
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_311_aten_linear_bias
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_312_aten_max_pool1d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_313_aten_max_pool1d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_314_aten_max_pool2d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_315_aten_max_pool2d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_316_aten_max_pool3d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_function_has_op_schema_317_aten_max_pool3d_with_indices
…
This pull request removes 37 skipped tests and adds 37 skipped tests. Note that renamed tests count towards both.
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_311_aten_max_pool1d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_312_aten_max_pool1d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_313_aten_max_pool2d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_314_aten_max_pool2d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_315_aten_max_pool3d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_316_aten_max_pool3d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_317_aten_scaled_dot_product_attention
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_318_aten__scaled_dot_product_flash_attention
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_319_aten__scaled_dot_product_efficient_attention
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_320_aten_scaled_dot_product_attention_bool_mask
…
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_312_aten_max_pool1d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_313_aten_max_pool1d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_314_aten_max_pool2d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_315_aten_max_pool2d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_316_aten_max_pool3d
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_317_aten_max_pool3d_with_indices
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_318_aten_scaled_dot_product_attention
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_319_aten__scaled_dot_product_flash_attention
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_320_aten__scaled_dot_product_efficient_attention
tests.function_libs.torch_lib.ops_test.TestFunctionValidity ‑ test_script_function_passes_checker_321_aten_scaled_dot_product_attention_bool_mask
…

♻️ This comment has been updated with latest results.

@shubhambhokare1 shubhambhokare1 merged commit 159e5bc into main Jun 28, 2024
36 of 47 checks passed
@shubhambhokare1 shubhambhokare1 deleted the sbhokare/glu-op branch June 28, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: torch_lib Related to the torch/aten function lib in development
Projects
Development

Successfully merging this pull request may close these issues.

[torchlib] Implement <OpOverload(op='aten.glu', overload='default')>
3 participants