Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test torch.onnx.export(..., dynamo=True) #1708

Merged
merged 42 commits into from
Jul 2, 2024
Merged

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Jun 25, 2024

No description provided.

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre self-assigned this Jun 25, 2024
@xadupre xadupre changed the title Test torch.onnx.export(..., dynama=True) Test torch.onnx.export(..., dynamo=True) Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 43.68421% with 107 lines in your changes missing coverage. Please review.

Project coverage is 75.58%. Comparing base (159e5bc) to head (81a1424).

Files Patch % Lines
onnxscript/tools/transformers_models/llama_test.py 34.14% 27 Missing ⚠️
...nxscript/tools/transformers_models/mistral_test.py 32.50% 27 Missing ⚠️
onnxscript/tools/transformers_models/phi3_test.py 27.02% 27 Missing ⚠️
onnxscript/tools/transformers_models/phi_test.py 50.00% 10 Missing ⚠️
onnxscript/tools/transformers_models/__init__.py 11.11% 8 Missing ⚠️
onnxscript/_internal/version_utils.py 89.47% 1 Missing and 1 partial ⚠️
onnxscript/tools/transformers_models/mistral.py 0.00% 2 Missing ⚠️
onnxscript/tools/transformers_models/phi3.py 0.00% 2 Missing ⚠️
onnxscript/tools/transformers_models/llama.py 50.00% 1 Missing ⚠️
onnxscript/tools/transformers_models/phi.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
- Coverage   76.17%   75.58%   -0.60%     
==========================================
  Files         240      240              
  Lines       25499    25653     +154     
  Branches     4551     4615      +64     
==========================================
- Hits        19424    19389      -35     
- Misses       5189     5385     +196     
+ Partials      886      879       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre marked this pull request as ready for review June 26, 2024 17:00
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Copy link
Collaborator

@gramalingam gramalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some description of the PR (what is it trying to fix?) would be helpful. I am a bit unclear about this.

@gramalingam
Copy link
Collaborator

We should also find out about python 3.8 support in pytorch ... if it is necessary there, we will need to continue supporting it

@gramalingam gramalingam merged commit 3244e92 into microsoft:main Jul 2, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants