Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iOS): Images don't render on iOS 14 with RN < 0.63.2 #260

Merged
merged 1 commit into from
Dec 17, 2020
Merged

fix(iOS): Images don't render on iOS 14 with RN < 0.63.2 #260

merged 1 commit into from
Dec 17, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Dec 15, 2020 •
edited
Loading

Description

This change monkey patches React Native on versions prior to 0.63.2 to
fix a bug with images not rendering when on iOS 14.

See facebook/react-native#29420.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

  1. Downgrade Example app to 0.62 
    diff --git a/example/package.json b/example/package.json
index 351eac3..3a1bff6 100644
--- a/example/package.json
+++ b/example/package.json
@@ -24,10 +24,10 @@
   "devDependencies": {
     "@babel/core": "^7.0.0",
     "mkdirp": "^0.5.1",
-    "react": "16.13.1",
-    "react-native": "0.63.3",
-    "react-native-macos": "0.63.1",
+    "react": "16.11.0",
+    "react-native": "0.62.2",
+    "react-native-macos": "0.62.16",
     "react-native-test-app": "../",
-    "react-native-windows": "0.63.10"
+    "react-native-windows": "0.62.17"
   }
 }
  2. Delete /example/ios/Podfile.lock before running pod install
  3. Build Example iOS app
Before After
Simulator Screen Shot - iPhone 12 Pro - 2020-12-16 at 09 09 55 Simulator Screen Shot - iPhone 12 Pro - 2020-12-16 at 09 10 13

@tido64 tido64 added the platform: iOS This affects iOS label Dec 15, 2020
@tido64 tido64 requested review from kelset and tom-un December 15, 2020 20:20
@tido64 tido64 force-pushed the tido/monkey-patch-image-rn62 branch from bf6a2a1 to 53458cd Compare December 16, 2020 07:52
@tido64
fix(iOS): Images don't render on iOS 14 with RN < 0.63.2
93eaf0c 
This change monkey patches React Native on versions prior to 0.63.2 to
fix a bug with images not rendering when on iOS 14.

See facebook/react-native#29420.
@tido64 tido64 force-pushed the tido/monkey-patch-image-rn62 branch from 53458cd to 93eaf0c Compare December 16, 2020 10:57
@tido64 tido64 marked this pull request as ready for review December 16, 2020 10:57
kelset
kelset reviewed Dec 16, 2020
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ios/ReactTestApp.xcodeproj/project.pbxproj Show resolved Hide resolved
@tido64 tido64 merged commit 39bb7da into master Dec 17, 2020
@tido64 tido64 deleted the tido/monkey-patch-image-rn62 branch December 17, 2020 00:57
@github-actions
Copy link

🎉 This PR is included in version 0.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset left review comments

@tom-un tom-un tom-un approved these changes

Assignees
No one assigned
Labels
platform: iOS This affects iOS released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tido64 @kelset @tom-un