More messages for common Store package download scenarios #4841

yao-msft · 2024-09-30T20:25:26Z

Rename downloaded file to contain platform architecture info, and a message for the option to filter packages to be downloaded
Message for "package does not support download"
Make licensing errors as warning, added a specific message for "Entra Id account does not have enough access to licensing"

Microsoft Reviewers: Open in CodeFlow

ryfu-msft · 2024-09-30T22:28:14Z

src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

@@ -2948,7 +2948,8 @@ Please specify one of them using the --source option to proceed.</value>
    <comment>{Locked="--rename"}</comment>
  </data>
  <data name="MSStoreDownloadAuthenticationNotice" xml:space="preserve">
-    <value>Microsoft Store package download requires Microsoft Entra Id authentication. Authentication prompt may appear when necessary. Authenticated information will be shared with Microsoft services for access authorization. For Microsoft Store package licensing, the Microsoft Entra Id account needs to have administrator access to the Microsoft Entra Id tenant.</value>
+    <value>Microsoft Store package download requires Microsoft Entra Id authentication. Authentication prompt may appear when necessary. Authenticated information will be shared with Microsoft services for access authorization. For Microsoft Store package licensing, the Microsoft Entra Id account needs to be member of Global Administrator, User Administrator, or License Administrator.</value>


Suggested change

<value>Microsoft Store package download requires Microsoft Entra Id authentication. Authentication prompt may appear when necessary. Authenticated information will be shared with Microsoft services for access authorization. For Microsoft Store package licensing, the Microsoft Entra Id account needs to be member of Global Administrator, User Administrator, or License Administrator.</value>

<value>Microsoft Store package download requires Microsoft Entra Id authentication. Authentication prompt may appear when necessary. Authenticated information will be shared with Microsoft services for access authorization. For Microsoft Store package licensing, the Microsoft Entra Id account needs to be a member of Global Administrator, User Administrator, or License Administrator.</value>

ryfu-msft · 2024-09-30T22:29:07Z

src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

+  </data>
+  <data name="MSStoreDownloadGetLicenseForbidden" xml:space="preserve">
+    <value>Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account is not member of Global Administrator, User Administrator, or License Administrator. Use --skip-license to skip retrieving Microsoft Store package license.</value>


Suggested change

<value>Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account is not member of Global Administrator, User Administrator, or License Administrator. Use --skip-license to skip retrieving Microsoft Store package license.</value>

<value>Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account is not a member of Global Administrator, User Administrator, or License Administrator. Use --skip-license to skip retrieving Microsoft Store package license.</value>

ryfu-msft · 2024-09-30T22:29:50Z

src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

+    <value>The Microsoft Store package does not support download command.</value>
+  </data>
+  <data name="APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED" xml:space="preserve">
+    <value>The Microsoft Store package does not support download command.</value>
+  </data>


nit:

Suggested change

<data name="MSStoreDownloadPackageDownloadNotSupported" xml:space="preserve">

<value>The Microsoft Store package does not support download command.</value>

</data>

<data name="APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED" xml:space="preserve">

<value>The Microsoft Store package does not support download command.</value>

</data>

<data name="MSStoreDownloadPackageDownloadNotSupported" xml:space="preserve">

<value>The Microsoft Store package does not support download.</value>

</data>

<data name="APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED" xml:space="preserve">

<value>The Microsoft Store package does not support download.</value>

</data>

ryfu-msft · 2024-09-30T22:31:54Z

src/AppInstallerSharedLib/Errors.cpp

@@ -219,6 +219,8 @@ namespace AppInstaller
            WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_SFSCLIENT_API_FAILED, "Failed to get Microsoft Store package download information."),
            WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_NO_APPLICABLE_SFSCLIENT_PACKAGE, "No applicable Microsoft Store package download information found."),
            WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED, "Failed to retrieve Microsoft Store package license."),
+            WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED, "The Microsoft Store package does not support download command."),


Suggested change

WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED, "The Microsoft Store package does not support download command."),

WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED, "The Microsoft Store package does not support download."),

ryfu-msft · 2024-09-30T22:32:35Z

src/AppInstallerSharedLib/Errors.cpp

@@ -219,6 +219,8 @@ namespace AppInstaller
            WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_SFSCLIENT_API_FAILED, "Failed to get Microsoft Store package download information."),
            WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_NO_APPLICABLE_SFSCLIENT_PACKAGE, "No applicable Microsoft Store package download information found."),
            WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED, "Failed to retrieve Microsoft Store package license."),
+            WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED, "The Microsoft Store package does not support download command."),
+            WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED_FORBIDDEN, "Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account does not have required privilege."),


Suggested change

WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED_FORBIDDEN, "Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account does not have required privilege."),

WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED_FORBIDDEN, "Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account does not have the required privilege."),

ryfu-msft · 2024-09-30T22:32:54Z

doc/windows/package-manager/winget/returnCodes.md

@@ -143,6 +143,8 @@ ms.localizationpriority: medium
 | 0x8A150081 | -1978335103 | APPINSTALLER_CLI_ERROR_SFSCLIENT_API_FAILED | Failed to get Microsoft Store package download information. |
 | 0x8A150082 | -1978335102 | APPINSTALLER_CLI_ERROR_NO_APPLICABLE_SFSCLIENT_PACKAGE | No applicable Microsoft Store package download information found. |
 | 0x8A150083 | -1978335101 | APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED | Failed to retrieve Microsoft Store package license. |
+| 0x8A150084 | -1978335100 | APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED | The Microsoft Store package does not support download command. |


Suggested change

| 0x8A150084 | -1978335100 | APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED | The Microsoft Store package does not support download command. |

| 0x8A150084 | -1978335100 | APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED | The Microsoft Store package does not support download. |

ryfu-msft · 2024-09-30T22:33:14Z

doc/windows/package-manager/winget/returnCodes.md

@@ -143,6 +143,8 @@ ms.localizationpriority: medium
 | 0x8A150081 | -1978335103 | APPINSTALLER_CLI_ERROR_SFSCLIENT_API_FAILED | Failed to get Microsoft Store package download information. |
 | 0x8A150082 | -1978335102 | APPINSTALLER_CLI_ERROR_NO_APPLICABLE_SFSCLIENT_PACKAGE | No applicable Microsoft Store package download information found. |
 | 0x8A150083 | -1978335101 | APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED | Failed to retrieve Microsoft Store package license. |
+| 0x8A150084 | -1978335100 | APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED | The Microsoft Store package does not support download command. |
+| 0x8A150085 | -1978335099 | APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED_FORBIDDEN | Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account does not have required privilege. |


Suggested change

| 0x8A150085 | -1978335099 | APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED_FORBIDDEN | Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account does not have required privilege. |

| 0x8A150085 | -1978335099 | APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED_FORBIDDEN | Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account does not have the required privilege. |

yao-msft · 2024-09-30T23:43:59Z

/azp run

azure-pipelines · 2024-09-30T23:44:07Z

Azure Pipelines successfully started running 1 pipeline(s).

yao-msft added 4 commits September 25, 2024 13:13

Change file name

4852587

more messages

5f6b62f

Move handling inside

78a2c83

tests

358d056

yao-msft requested a review from a team as a code owner September 30, 2024 20:25

fix

c3bb68f

ryfu-msft previously approved these changes Sep 30, 2024

View reviewed changes

yao-msft linked an issue Sep 30, 2024 that may be closed by this pull request

WinGet download has unhelpful error text when download not supported. #4645

Closed

pr comments

47f227f

yao-msft dismissed ryfu-msft’s stale review via 47f227f September 30, 2024 22:56

microsoft-github-policy-service bot added Issue-Feature This is a feature request for the Windows Package Manager client. Area-Output Issue related to CLI output labels Sep 30, 2024

ryfu-msft approved these changes Sep 30, 2024

View reviewed changes

yao-msft linked an issue Sep 30, 2024 that may be closed by this pull request

WinGet Download presents error when it should be a warning. #4643

Closed

yao-msft merged commit 6ea1362 into microsoft:master Oct 1, 2024
9 checks passed

yao-msft deleted the downloadmessages branch October 1, 2024 03:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More messages for common Store package download scenarios #4841

More messages for common Store package download scenarios #4841

yao-msft commented Sep 30, 2024 •

edited by microsoft-github-policy-service bot

Loading

ryfu-msft Sep 30, 2024

ryfu-msft Sep 30, 2024

ryfu-msft Sep 30, 2024

ryfu-msft Sep 30, 2024

ryfu-msft Sep 30, 2024

ryfu-msft Sep 30, 2024

ryfu-msft Sep 30, 2024

yao-msft commented Sep 30, 2024

azure-pipelines bot commented Sep 30, 2024

	<value>Microsoft Store package download requires Microsoft Entra Id authentication. Authentication prompt may appear when necessary. Authenticated information will be shared with Microsoft services for access authorization. For Microsoft Store package licensing, the Microsoft Entra Id account needs to be member of Global Administrator, User Administrator, or License Administrator.</value>
	<value>Microsoft Store package download requires Microsoft Entra Id authentication. Authentication prompt may appear when necessary. Authenticated information will be shared with Microsoft services for access authorization. For Microsoft Store package licensing, the Microsoft Entra Id account needs to be a member of Global Administrator, User Administrator, or License Administrator.</value>

	<value>Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account is not member of Global Administrator, User Administrator, or License Administrator. Use --skip-license to skip retrieving Microsoft Store package license.</value>
	<value>Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account is not a member of Global Administrator, User Administrator, or License Administrator. Use --skip-license to skip retrieving Microsoft Store package license.</value>

	WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED, "The Microsoft Store package does not support download command."),
	WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED, "The Microsoft Store package does not support download."),

	\| 0x8A150084 \| -1978335100 \| APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED \| The Microsoft Store package does not support download command. \|
	\| 0x8A150084 \| -1978335100 \| APPINSTALLER_CLI_ERROR_SFSCLIENT_PACKAGE_NOT_SUPPORTED \| The Microsoft Store package does not support download. \|

	\| 0x8A150085 \| -1978335099 \| APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED_FORBIDDEN \| Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account does not have required privilege. \|
	\| 0x8A150085 \| -1978335099 \| APPINSTALLER_CLI_ERROR_LICENSING_API_FAILED_FORBIDDEN \| Failed to retrieve Microsoft Store package license. The Microsoft Entra Id account does not have the required privilege. \|

More messages for common Store package download scenarios #4841

More messages for common Store package download scenarios #4841

Conversation

yao-msft commented Sep 30, 2024 • edited by microsoft-github-policy-service bot Loading

Microsoft Reviewers: Open in CodeFlow

ryfu-msft Sep 30, 2024

Choose a reason for hiding this comment

ryfu-msft Sep 30, 2024

Choose a reason for hiding this comment

ryfu-msft Sep 30, 2024

Choose a reason for hiding this comment

ryfu-msft Sep 30, 2024

Choose a reason for hiding this comment

ryfu-msft Sep 30, 2024

Choose a reason for hiding this comment

ryfu-msft Sep 30, 2024

Choose a reason for hiding this comment

ryfu-msft Sep 30, 2024

Choose a reason for hiding this comment

yao-msft commented Sep 30, 2024

azure-pipelines bot commented Sep 30, 2024

yao-msft commented Sep 30, 2024 •

edited by microsoft-github-policy-service bot

Loading