Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle installers blocked by defender virus scan #165

Merged
merged 6 commits into from
Sep 13, 2021
Merged

Handle installers blocked by defender virus scan #165

merged 6 commits into from
Sep 13, 2021

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Sep 12, 2021 •
edited by ghost
Loading

This PR adds the following changes:

  • Additional documentation in the security.md file regarding Virus and Threat Protection
  • Catches IOException which is thrown when a downloaded installer is blocked by defender scan.
  • Reformatting Exception handling
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner September 12, 2021 16:42
palenshus
palenshus previously requested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ghost ghost removed the Needs-Author-Feedback label Sep 13, 2021
@palenshus palenshus dismissed their stale review September 13, 2021 18:21

revoking review

palenshus
palenshus requested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ghost ghost removed the Needs-Author-Feedback label Sep 13, 2021
palenshus
palenshus approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@palenshus palenshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryfu-msft ryfu-msft merged commit 04ea74d into main Sep 13, 2021
@ryfu-msft ryfu-msft deleted the securityHelp branch September 13, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palenshus palenshus palenshus approved these changes

@denelon denelon denelon approved these changes

Assignees
No one assigned
Labels
Issue-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryfu-msft @palenshus @denelon