Add test for installer properties override #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
mdanish-kh
force-pushed
the
testPropOverrides
branch
from
429359f
to
58ac828
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Items at root level are not modified #211
After #409 got merged, I looked at the issue tracker and realized the PR also fixed another issue i.e., #211. PR #409 introduced the behavior that at the start of the update (both autonomous and interactive) the root fields are shifted to installer level and any previous values are overwritten by the root values.
Expected flow:
So now, you won't get a behavior of root fields and installer fields being different/not updated as described in the linked issue.
This PR simply adds a test case to verify this behavior. The root values are different from installer level and will become common between all installers after the override so they're shifted back to the root at the end of the update. I know I may been overkill with the assert statements but just wanted to be very sure 😄 Though I wish there was a way to update the ProductCode in the test update for more coverage.
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-create/pull/413&drop=dogfoodAlpha