Avoid creating installer node with duplicate NestedInstallerFile #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced with PR #415 where manifests generated for certain ZIP installers i.e., that have common NestedInstallerFiles in base manifest across each installer node were incorrect. The code before #415 worked with distinct relative file paths. In #415, the behavior was modified to use the whole NestedInstallerFile object instead of RelativeFilePaths only but the code was not updated to have distinct NestedInstallerFiles object added into baseInstaller. This PR fixes that behavior.
The previous tests didn't catch this bug. Added a new test case that covers this behavior.
Manifests to test with
Some examples to compare the behavior with current main branch build and this PR's build:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-create/pull/419&drop=dogfoodAlpha