Null check for sequences comparison #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
mdanish-kh
force-pushed
the
nullSequenceHandling
branch
2 times, most recently
from
c41a06c
to
f8ee221
Compare
mdanish-kh
force-pushed
the
nullSequenceHandling
branch
from
f8ee221
to
233e9f4
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERROR: Value cannot be null. (Parameter 'source')#429The exception is thrown at
winget-create/src/WingetCreateCore/Common/GitHub.cs
Line 155 in 44a102a
then
winget-create/src/WingetCreateCore/Common/Serialization.cs
Line 100 in 44a102a
The installer manifest contains dependencies object with some null List sequences (WindowsFeatures, WindowsLibraries, ExternalDependencies). The Equals() method for Dependencies seems to be used externally while serializing the manifest and because null values are not handled properly, an exception is thrown.
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-create/pull/432&drop=dogfoodAlpha