Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace argument for removing a previous manifest #440

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Aug 27, 2023

Example PR made with --replace:

There doesn't seem to be a great way to make an option accept optional values. Followed the recommendations listed here: commandlineparser/commandline#674


Microsoft Reviewers: Open in CodeFlow

@mdanish-kh mdanish-kh requested a review from a team as a code owner August 27, 2023 12:39
@mdanish-kh mdanish-kh requested review from yao-msft and ryfu-msft and removed request for a team August 27, 2023 12:39
@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 27, 2023
@mdanish-kh
Copy link
Contributor Author

I will be following up with a PR to have "replace" work automatically for vanity URLs provided this gets approved

src/WingetCreateCLI/Commands/UpdateCommand.cs Outdated Show resolved Hide resolved
doc/update.md Outdated Show resolved Hide resolved
src/WingetCreateCore/Common/GitHub.cs Show resolved Hide resolved
@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft
Copy link
Contributor

@mdanish-kh , Once this PR gets checked, I will work on pulling in the new localized strings from this PR once they are generated and cutting a new release :)

@mdanish-kh
Copy link
Contributor Author

@ryfu-msft Thanks, I do have a quick PR incoming after this (to address #72) but I don't mind if that can wait until the next release

@ryfu-msft
Copy link
Contributor

@ryfu-msft Thanks, I do have a quick PR incoming after this (to address #72) but I don't mind if that can wait until the next release

I'm happy to wait for that since that will be a really nice addition

@ryfu-msft ryfu-msft merged commit a71c11d into microsoft:main Sep 12, 2023
4 checks passed
@mdanish-kh mdanish-kh deleted the removePreviousVersion branch September 12, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "replace" argument to update
2 participants