Update regex for finding architecture from URL #551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With how the current logic for matching arch from URL works, an
x86_x64
type pattern would always match bothx64
andx86
and fail to get a unique match. This PR updates the pattern matching to only check for x86 if it doesn't match anx86_64
or similar patternIssue can be repro with an example manifest:
If you run it with interactive update, it will result in a manifest with duplicate architectures.