Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding schema link headers to serialized manifests #63

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Adding schema link headers to serialized manifests #63

merged 3 commits into from
Jun 4, 2021

Conversation

palenshus
Copy link
Contributor

@palenshus palenshus commented Jun 4, 2021 •
edited by ghost
Loading

Resolves #16

Microsoft Reviewers: Open in CodeFlow

@palenshus palenshus requested a review from ryfu-msft June 4, 2021 00:45
@palenshus palenshus requested a review from a team as a code owner June 4, 2021 00:45
@ghost ghost added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 4, 2021
@palenshus palenshus enabled auto-merge (squash) June 4, 2021 06:13
ryfu-msft
ryfu-msft requested changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@ryfu-msft ryfu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just one extra change needed

src/WingetCreateCLI/Program.cs Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback label Jun 4, 2021
ryfu-msft
ryfu-msft approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@ryfu-msft ryfu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost removed the Needs-Author-Feedback label Jun 4, 2021
@palenshus palenshus merged commit a5a01e5 into main Jun 4, 2021
@palenshus palenshus deleted the palenshus/headercomment branch June 4, 2021 20:02
@OfficialEsco
Copy link

How will this look?

I would very much prefer if wingetcreate, wingetbot and YamlCreate.ps1 use the same setup

# Created using wingetcreate
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.0.0.schema.json
PackageIdentifier: RARLab.WinRAR

# Automatically updated by the winget bot at 2021/Jun/09
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.0.0.schema.json
PackageIdentifier: RARLab.WinRAR

# Created using YamlCreate.ps1
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.0.0.schema.json
PackageIdentifier: RARLab.WinRAR

This would hopefully cause a few less issues when updating manifests
@denelon

@palenshus
Copy link
Contributor Author

palenshus commented Jun 14, 2021 •
edited
Loading

Hi Esco, yep that's more or less how it'll look, except with the wingetcreate version as well:

  # Created using wingetcreate 0.2.0.18
  # yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.0.0.schema.json
  
  PackageIdentifier: Foo.Bar

@OfficialEsco
Copy link

Hi Esco, yep that's more or less how it'll look, except with the wingetcreate version as well:

  # Created using wingetcreate 0.2.0.18
  # yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.0.0.schema.json
  
  PackageIdentifier: Foo.Bar

Hmm okay, aslong as we can get a standardized header between the yaml creators i'm happy

@denelon denelon mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryfu-msft ryfu-msft ryfu-msft approved these changes

Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JSON schema to manifests
3 participants
@palenshus @OfficialEsco @ryfu-msft