[YamlCreate] Request ARP Values on Quick Update #129471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
microsoft-github-policy-service
bot
added
the
Needs-Attention
mdanish-kh
reviewed
Dec 6, 2023
microsoft-github-policy-service
bot
removed
the
Needs-Attention
mdanish-kh
approved these changes
Dec 6, 2023
microsoft-github-policy-service
bot
added
the
Moderator-Approved
denelon
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, YamlCreate ignores AppsAndFeaturesEntries entirely. This PR begins the work of adding support for them.
The support is currently limited to applications with Existing ARP entries and only in the Quick Update flow.
The support also skips ProductCode and UpgradeCode as there is complexity around those fields related to when they have been fetched automatically from the updated application.
If there are entries that exist, the script will now prompt users to validate that the entry is correct. Providing no response to the prompt will keep the entry as it was.
cc @mdanish-kh
Microsoft Reviewers: Open in CodeFlow