Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make KeyTag extend Any so we can tag value classes #1015

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Make KeyTag extend Any so we can tag value classes #1015

merged 1 commit into from
Apr 26, 2020

Conversation

joroKr21
Copy link
Collaborator

Same as #801

@joroKr21 joroKr21 self-assigned this Apr 25, 2020
@joroKr21 joroKr21 added this to the shapeless-2.4.0 milestone Apr 25, 2020
milessabin
milessabin approved these changes Apr 26, 2020
View reviewed changes
Copy link
Owner

@milessabin milessabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milessabin milessabin merged commit d375218 into milessabin:master Apr 26, 2020
@joroKr21 joroKr21 deleted the field-type-any branch April 26, 2020 19:35
@joroKr21 joroKr21 mentioned this pull request Apr 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milessabin milessabin milessabin approved these changes

Assignees

@joroKr21 joroKr21

Labels
None yet
Projects
None yet
Milestone
shapeless-2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joroKr21 @milessabin