Set apple color space automatically

[wyuenho]

Why introduce an option when it can be done automatically? :P

This color space problem only ever exists on the NS port, so I'm pretty sure this is safe.

References: #54 #141

https://developer.apple.com/documentation/appkit/nsdisplaygamut/nsdisplaygamutsrgb?language=objc

https://en.wikipedia.org/wiki/Darwin_(operating_system)#Release_history

[wyuenho]

Hold on, I'm going to fix this up, this is only true for macOS 10.12+

[milkypostman]

i don't think it's true that it only exists on the ns port. i believe when i originally introduced this it was a problem on the macport too?

[wyuenho]

No Mitsuharu Yamamoto's Mac port is completely fine. I just switched over from the Mac port to the NS port so I noticed this issue.

[wyuenho]

Actually, judging from the ticket, it's possible it's gone as far back to 10.9, and only is a problem when ns-use-srgb-colorspace is set to t. I'm going to test it a bit more. Don't merge this yet.

[wyuenho]

ns-use-srgb-colorspace 's doc suggests this issue could affect systems as far back as 10.7. I've fixed the PR now.

[wyuenho]

@milkypostman Happy New Year! How does this PR look?

[milkypostman]

why not a defcustom here?

[wyuenho]

Because this variable is set automatically. It takes cares of all the cases where it needs to be set, there's no need to expose an easy way to customize it. In the one in a million chance where you do need to customize it, you can just use setq.

…

On 4 Jan 2019, at 4:58 am, Donald Curtis ***@***.***> wrote: @milkypostman commented on this pull request. In powerline-separators.el: > @@ -29,7 +29,18 @@ (require 'cl-lib) (require 'color) -(defvar powerline-image-apple-rgb) +(defvar powerline-image-apple-rgb why not a defcustom here? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.