Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove max version limit for graphql-core #1123

Closed
wants to merge 3 commits into from

Conversation

tonyrewin
Copy link

then gql will support more async transports

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1123 (594f570) into master (a9cca4f) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is 70.00%.

@@           Coverage Diff           @@
##           master    #1123   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files         115      115           
  Lines        7762     7763    +1     
=======================================
+ Hits         7593     7594    +1     
  Misses        169      169           
Files Coverage Δ
ariadne/asgi/handlers/graphql_ws.py 98.71% <100.00%> (+<0.01%) ⬆️
ariadne/types.py 98.38% <ø> (+4.18%) ⬆️
tests/asgi/test_websockets_graphql_transport_ws.py 100.00% <100.00%> (ø)
tests/asgi/test_websockets_graphql_ws.py 100.00% <100.00%> (ø)
ariadne/exceptions.py 88.00% <57.14%> (-12.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rafalp
Copy link
Contributor

rafalp commented Oct 6, 2023

I don't like this change on a basis that people installing Ariadne will have to keep up themselves with it's compatibility with future GraphQL Core releases. And when those are incompatible, we will be the first ones to take heat for it, as we've been in the past.

@rafalp
Copy link
Contributor

rafalp commented Oct 6, 2023

Which async transport do you want to use that's currently not supported by Ariadne?

I understand you want to use GraphQL Core 3.3 alpha - other ways exist to do this like having custom version of Ariadne on GitHub and installing that one instead of ariadne from Pypi.

@rafalp rafalp added the waiting Waiting for action from OP label Oct 6, 2023
@tonyrewin
Copy link
Author

Which async transport do you want to use that's currently not supported by Ariadne?

I understand you want to use GraphQL Core 3.3 alpha - other ways exist to do this like having custom version of Ariadne on GitHub and installing that one instead of ariadne from Pypi.

i wanted to use httpx for the latest only version of gql

@rafalp
Copy link
Contributor

rafalp commented Nov 7, 2023

Sorry for late response but this is not going to happen. If you need Ariadne with GraphQL Core 3.3, please make a fork. Unpinning this dependency from Ariadne is a recipe for disaster.

@rafalp rafalp closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting for action from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants