fix(frontend): Safariでプラグインが複数ある場合に正常に読み込まれない問題を修正 #10290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #10290 +/- ##
===========================================
- Coverage 73.37% 72.37% -1.00%
===========================================
Files 809 715 -94
Lines 77515 66146 -11369
Branches 5401 5282 -119
===========================================
- Hits 56875 47874 -9001
+ Misses 20640 18272 -2368 see 94 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rinsuki
reviewed
Mar 11, 2023
Co-authored-by: rinsuki <428rinsuki+git@gmail.com>
Co-authored-by: rinsuki <428rinsuki+git@gmail.com>
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Plugin:register_post_form_actionを使用したプラグインを公開した際に、Safariを使用している方々から「1つは反映されているがプラグインが反映されていない」との報告を受けたため、Safariでも正常にプラグインが読み込めるように修正しました。同様のissueが #9829 にありました。
Why
#9829 の問題を調べた結果、createAiScriptEnvで
ReferenceError: Cannot access uninitialized variableが発生しており、それに関連した他のissue( sveltejs/kit#2889 sveltejs/kit#7805 )からwebkitのバグが問題であるらしく、ロード時に同時に読み込もうとすると起こるバグのようなので、importの処理の開始を少し遅らせることによって問題が解決した。setTimeoutの値が0の場合でも読み込まれていたので、読み込み速度にあまり影響が出ないようにしてあります。Additional info (optional)
Checklist