Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve detection of sound hardware from configuration #2253

Merged
merged 12 commits into from
Oct 1, 2019
Merged

improve detection of sound hardware from configuration #2253

merged 12 commits into from
Oct 1, 2019

Commits on Sep 1, 2019

  1. don't identify PortAudio devices by PaDeviceIndex in configuration 

    PortAudio provides no guarantees that the PaDeviceIndex for any
device will be stable across restarts of Mixxx. Abusing the
PaDeviceIndex as a persistent identifier caused Mixxx to falsely
claim that audio interfaces were not available and annoyingly
require the user to reconfigure all their sound I/O even when
nothing about the available sound hardware actually changed. It
is the responsibility of the sound API to provide persistent
names for devices to PortAudio.
    @Be-ing
    Be-ing committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    2b900a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. track device name, ALSA device, and PortAudio device index separately 

    This allows for more reliable identification of hardware devices from
the configuration file so users do not need to reconfigure their sound
hardware as often as before.
    @Be-ing
    Be-ing committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    725a15a View commit details
    Browse the repository at this point in the history

  2. make SoundDeviceId qDebuggable

    @Be-ing
    Be-ing committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    28603cf View commit details
    Browse the repository at this point in the history

  3. alsaDeviceName -> alsaHwDevice 

    It isn't really a name, just an ID that ALSA defines.
    @Be-ing
    Be-ing committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    a35a392 View commit details
    Browse the repository at this point in the history

  4. DlgPrefSound: don't reinitialize sound hardware when nothing changes

    @Be-ing
    Be-ing committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    8ffb16e View commit details
    Browse the repository at this point in the history

  5. SoundDeviceId: add comments; code formatting

    @Be-ing
    Be-ing committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    9d0bc65 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. DlgPrefSoundItem: use default-constructed SoundDeviceId for "None"

    @Be-ing
    Be-ing committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    b115e44 View commit details
    Browse the repository at this point in the history

  2. SoundDevicePortAudio: make ALSA hw device regex a constant

    @Be-ing
    Be-ing committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    1ce84d7 View commit details
    Browse the repository at this point in the history

  3. SoundManagerConfig: use named constants for XML attributes & elements 

    This ensures the strings are the same in the readFromDisk and
writeToDisk functions.
    @Be-ing
    Be-ing committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    1e5d6a4 View commit details
    Browse the repository at this point in the history

  4. SoundDeviceId: simplify constructor

    @Be-ing
    Be-ing committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    09a3449 View commit details
    Browse the repository at this point in the history

  5. SoundManagerConfig: make constructor explicit

    @Be-ing
    Be-ing committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    c61cef4 View commit details
    Browse the repository at this point in the history

  6. overcomplicate code to avoid reconfiguring sound HW one more time 

    ... which users have been doing for years anyway. Revert this
commit after releasing Mixxx 2.2.3.
    @Be-ing
    Be-ing committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    5e58431 View commit details
    Browse the repository at this point in the history