Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to 3.11-slim vulnerability fixed version #9

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Revert to 3.11-slim vulnerability fixed version #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4361641
Merge pull request #6 from mjanez/main
mjanez Feb 8, 2024
1beba0a
Revert to 3.11-slim vulnerability fixed version
mjanez Feb 8, 2024
bc6b054
Fix branch name in actions
mjanez Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Test ckan-mqa images (PR)
on:
pull_request:
branches:
- master
- main
- 'ckan-mqa-*.*.*'
- '!dev/ckan-mqa-*.*.*'
- '!feature/*'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
types:
- closed
branches:
- master
- main
- 'ckan-mqa-*.*.*'
- '!dev/ckan-mqa-*.*.*'
- '!feature/*'
Expand Down
2 changes: 1 addition & 1 deletion ckan-mqa/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.13.0a3-slim
FROM python:3.11-slim
LABEL maintainer="mnl.janez@gmail.com"

ENV APP_DIR=/app
Expand All @@ -9,7 +9,7 @@
ENV DEV_MODE=False
ENV TIMEOUT=20

RUN apt-get -q -y update && \

Check warning on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/test-ckan-mqa-pr:latest 

Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`

Check notice on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/test-ckan-mqa-pr:latest 

Delete the apt-get lists after installing something

Check warning on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/test-ckan-mqa-pr:latest 

Avoid use of cache directory with pip. Use `pip install --no-cache-dir <package>`

Check warning on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/test-ckan-mqa-pr:latest 

Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>` or `pip install --requirement <requirements file>`

Check notice on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/test-ckan-mqa-pr:latest 

Avoid use of wget without progress bar. Use `wget --progress=dot:giga <url>`. Or consider using `-q` or `-nv` (shorthands for `--quiet` or `--no-verbose`).

Check notice on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/test-ckan-mqa-pr:latest 

Avoid additional packages by specifying `--no-install-recommends`

Check failure on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/build-docker-push:latest 

DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`

Check failure on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/build-docker-push:latest 

DL3009 info: Delete the apt-get lists after installing something

Check failure on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/build-docker-push:latest 

DL3042 warning: Avoid use of cache directory with pip. Use `pip install --no-cache-dir <package>`

Check failure on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/build-docker-push:latest 

DL3013 warning: Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>` or `pip install --requirement <requirements file>`

Check failure on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/build-docker-push:latest 

DL3047 info: Avoid use of wget without progress bar. Use `wget --progress=dot:giga <url>`. Or consider using `-q` or `-nv` (shorthands for `--quiet` or `--no-verbose`).

Check failure on line 12 in ckan-mqa/Dockerfile

View workflow job for this annotation

GitHub Actions / runner/build-docker-push:latest 

DL3015 info: Avoid additional packages by specifying `--no-install-recommends`
apt-get install -y wget && \
DEBIAN_FRONTEND=noninteractive apt-get -yq install gettext-base && \
wget -O /wait-for https://raw.github.com/eficode/wait-for/v2.2.3/wait-for && \
Expand Down
2 changes: 1 addition & 1 deletion ckan-mqa/Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.13.0a3-slim
FROM python:3.11-slim
LABEL maintainer="mnl.janez@gmail.com"

ENV APP_DIR=/app
Expand Down