Fix virtio-sock pci_vtsock_proc_tx uninitialized memory use (GHSL-202…

…1-057) Signed-off-by: Frederic Dalleau <frederic.dalleau@docker.com>
moby · Jun 24, 2021 · af5eba2 · af5eba2
1 parent 41272a9
commit af5eba2
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/lib/pci_virtio_sock.c b/src/lib/pci_virtio_sock.c
@@ -1121,6 +1121,11 @@ static void pci_vtsock_proc_tx(struct pci_vtsock_softc *sc,
 	size_t pulled;
 
 	iovec_len = vq_getchain(vq, &idx, iov, VTSOCK_MAXSEGS, flags);
+	if (iovec_len < 0) {
+		fprintf(stderr, "TX: failed to get chain at idx %"PRIx16"\n", idx);
+		return;
+	}
+
 	assert(iovec_len <= VTSOCK_MAXSEGS);
 
 	DPRINTF(("TX: chain with %d buffers at idx %"PRIx16"\n",