Configurable Strictness in XmlSuite #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical fix for broken TravisCI build as explained in https://travis-ci.community/t/install-of-oracle-jdk8-is-failing/4365/2
parameter key is "org.mockito.testng.strictness" - upgrade TestNG to minimum version (6.3.1 -> 6.4) required to get ISuite.getParameters from ITestResult - separate test task for lenient strictness tests + hook up to test task - not testing Strictness.WARN - can't test this properly because that requires an accessible MockitoLogger
mouyang
force-pushed
the
set-strictness
branch
from
30632b9
to
5c1ed31
Compare
|
Closing until PR #9 gets approved.
|
|
Created a new PR - I didn't know you can't reopen a PR if you do a rebase and force push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My reason for doing this is outlined in this issue comment
git commit body
parameter key is "org.mockito.testng.strictness"