Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicator-underglow: allow omissions; allow right-hand battery indicators. #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Mar 11, 2024

  1. indicator-underglow: allow omissions; allow right-hand battery indica…

    …tors.
    
    This commit does two things:
    
    1. Provides default values for all indicator-underglow properties, which
       allows you to omit them entirely if you do not want that indicator.
    2. Allows the right side to specify battery indicators.
    
    I changed the phrasing of the battery left/right properties to be
    self/other instead.
    
    For (2), note that this currently does not work with the default Glove80
    definition for the magic (indicator) key, since the right side does not
    received the macro-wrapped `&rgb_ug RGB_STATUS` keypress. See the
    usptream issue zmkfirmware#1494 for more.
    (I resolved this for my own build by incorporating the changes from
    zmkfirmware#1630.)
    seansfkelley committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    188ce5b View commit details
    Browse the repository at this point in the history