app.py: skip before_wiki and teardown_wiki for static content #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the before_wiki and teardown wiki handling for static content such as CSS files.
The before_wiki function is needed to open the storage, set up the user - important for ACL handling, setting up the Jinja environment, etc.. The static content is public and therefore the before_wiki and teardown_wiki code is unnecessary overhead.
The request_path / url has been added to the timer message in the debug log.
Moved clock stop to the end of teardown_wiki. Is there a reason for the existing code sequence?
Related to #1725.