-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't log if processes are running and within bounds #111
Conversation
These logs are creating quite a bit of log spew on the github.com servers, and I don't think they really provide much value?
//cc @tmm1 |
Seems reasonable to me. |
Will this stop the logging? Doesn't look right.. We probably want |
Good point, tmm1. |
I think this is where the logging happens, but I'm not really sure: https://github.com/scottjg/god/blob/master/lib/god/task.rb#L376-377 |
from what i understand it goes...
the call to the logs in question look like this:
i could only find the string "process is running" in lib/god/conditions/process_running.rb. also, the only place that that did i miss a thing? what else would we want to use |
Maybe it would be better to change the log level to debug if the status is ok. |
afaict it will already be debug logged here: https://github.com/scottjg/god/blob/master/lib/god/task.rb#L488 |
Empty arrays will let God::Task#handle_poll skip logging stuff in the INFO loglevel.
appears to work ok on one of our staging frontends. |
Don't log if processes are running and within bounds
These logs are creating quite a bit of log spew on the github.com
servers, and I don't think they really provide much value?