The Ruby 1.9 fixes should only apply to 1.9.0 and 1.9.1. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should never have been applied to 1.9.2 and above because these already include the fixes. Furthermore, the fixes actually break under Ruby 2.0.
|
The second I stumbled upon the issue, someone contributes a fix. Fantastic! Thank you so much, red headband-ed stranger! |
|
Thanks! |
eric
added a commit
that referenced
this pull request
Feb 25, 2013
The Ruby 1.9 fixes should only apply to 1.9.0 and 1.9.1.
|
Thanks for breaking your silence and merging this. Any chance of a release? I know it's only a tiny change but without it, all Ruby 2.0 users will need to install this from git. |
|
Just released 8cbbba2 as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They should never have been applied to 1.9.2 and above because these already include the fixes. Furthermore, the fixes actually break under Ruby 2.0.