Fix fatal exception when pid is nil #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pid may return a nil value (if never found in pid_file) causing Process.kill to throw an exception (TypeError: no implicit conversion from nil to integer). We should check to make sure the pid isn't nil before attempting to kill it. Warn (once) about the missing pid. Don't interrupt polling in case a valid pid_file shows up while polling.
|
Great idea! Thanks! |
eric
added a commit
that referenced
this pull request
Mar 6, 2014
Fix fatal exception when pid is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pid may return a nil value (if never found in pid_file) causing Process.kill to throw an exception (TypeError: no implicit conversion from nil to integer). We should check to make sure the pid isn't nil before attempting to kill it. Warn (once) about the missing pid. Don't interrupt polling in case a valid pid_file shows up while polling.