Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ssl in http_response_code condition #36

Merged
merged 3 commits into from
Dec 17, 2011

Conversation

buffym
Copy link
Contributor

@buffym buffym commented Jan 26, 2011

I added an optional argument 'ssl' for the http_response_code condition to allow monitoring https links. Cavat - It does not verify the certificate of the monitored site.

@mojombo
Copy link
Owner

mojombo commented May 24, 2011

This causes a number of test failures. Could you go through it again and make sure all tests pass?

@buffym
Copy link
Contributor Author

buffym commented May 24, 2011

Yes, sorry, I will check it out as soon as I get a chance. My very first pull req. for an open source project, so thanks for being gentle!

Buffy

On May 24, 2011, at 6:46 PM, mojomboreply@reply.github.com wrote:

This causes a number of test failures. Could you go through it again and make sure all tests pass?

Reply to this email directly or view it on GitHub:
#36 (comment)

@mojombo
Copy link
Owner

mojombo commented May 25, 2011

No worries. Thanks so much for taking the time to make a contribution! If you need any help with anything, just give a holler.

@buffym
Copy link
Contributor Author

buffym commented Aug 12, 2011

I think I've got the broken tests fixed, and added support for supplying a ca_file to avoid verification warnings, and allow for greater security if desired. New to mocha, so let me know if the test changes I made aren't quite right.

@mojombo mojombo merged commit b2fe455 into mojombo:master Dec 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants