Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a simple way to prevent bundler auto-loading #97

Merged
merged 2 commits into from
Sep 18, 2012

Conversation

eric
Copy link
Collaborator

@eric eric commented May 2, 2012

Most cases of problems we see with conflicts with sugar.rb are due to bundler
autoloading god into Rails processes when it really doesn't need to be.

@eric
Copy link
Collaborator Author

eric commented May 2, 2012

Related: #17, #61, #96

Most cases of problems we see with conflicts with sugar.rb are due to bundler
autoloading god into Rails processes when it really doesn't need to be.
@eric
Copy link
Collaborator Author

eric commented May 2, 2012

I've had conversations with @mojombo about the best way to avoid bundler auto-loading.

I was contemplating moving everything in lib/god.rb into a different file in lib/god/, but @mojombo thought this would be simpler.

@eric
Copy link
Collaborator Author

eric commented May 9, 2012

The other suggestion @mojombo had was $load_god_for_great_justice.

@yaotti
Copy link

yaotti commented Jul 23, 2012

+1
This resolves the conflicts in my case too but I wonder why you deleted require 'rubygems' in bin/god and test/helper.rb.

@eric
Copy link
Collaborator Author

eric commented Jul 23, 2012

Here are some details from rtomayko on why require 'rubygems' is not needed (and isn't good): http://tomayko.com/writings/require-rubygems-antipattern

@yaotti
Copy link

yaotti commented Jul 23, 2012

I see, thank you!

eric added a commit that referenced this pull request Sep 18, 2012
Provide a simple way to prevent bundler auto-loading
@eric eric merged commit b046fd8 into mojombo:master Sep 18, 2012
@eric
Copy link
Collaborator Author

eric commented Sep 18, 2012

Released as 0.13.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants