[ReactDevTools] add custom error view for caught error #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2022
mondaychen
force-pushed
the
custom_error_debug_tools_2
branch
from
dad75d3
to
a1bec07
Compare
mondaychen
force-pushed
the
user_error_view_1
branch
from
1ee3c9f
to
4a1f36b
Compare
mondaychen
force-pushed
the
custom_error_debug_tools_2
branch
from
a1bec07
to
e10125d
Compare
Now that 18.0 is out, the next minor is 18.1
React 18 is just React now.
mondaychen
force-pushed
the
user_error_view_1
branch
from
4a1f36b
to
228a52f
Compare
* Test suite for hydration diff warnings * Test both variants * Add more edge cases
* SS2 fixture not working locally fix * Fix prettier issue * prettier excess line fix * Update render.js * Update README.md Co-authored-by: dan <dan.abramov@gmail.com>
…acebook#24236) * Delay showing fallback if hydrating suspends * Fix up * Include all non-urgent lanes * Moar tests * Add test for transitions
…facebook#24216) * [ReactDebugTools] wrap uncaught error from rendering user's component * fix lint * make error names more package specific * update per review comments * fix tests * fix lint * fix tests * fix lint * fix error name & nits * try catch instead of mocking error * fix test for older node.js version * avoid false positive from try-catch in tests
mondaychen
force-pushed
the
user_error_view_1
branch
from
228a52f
to
8236fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves facebook#24096
Summary
Add custom views to handle unknown errors reported from backend
How did you test this change?
Tested using the app in facebook#24096
The error shown in dev tools extension:
When user switch to console, the detailed error and the original error is logged there. In this case, the original error is an object instead of a JS Error
Custom error view to notify user to upgrade dev tools:
