ci(hardhat): change code #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
force-pushed
the
fix/hardhat-ci-collateral
branch
from
6adf798
to
d39434f
Compare
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
pakim249CAL,
MathisGD,
Jean-Grimal and
makcandrov
MerlinEgalite
previously approved these changes
Jul 20, 2023
Rubilmax
force-pushed
the
fix/hardhat-ci-collateral
branch
from
61153d4
to
c77c804
Compare
MerlinEgalite
approved these changes
Jul 21, 2023
QGarchery
approved these changes
Jul 21, 2023
makcandrov
approved these changes
Jul 21, 2023
Jean-Grimal
approved these changes
Jul 21, 2023
MathisGD
reviewed
Jul 25, 2023
| await blue.connect(user).withdraw(market, amount.div(2), user.address); | ||
| } | ||
| if (random() < 2 / 3) { | ||
| await blue.connect(user).supply(market, amount, user.address); |
There was a problem hiding this comment.
no risk that amount is zero here ? at line 135 we check it at least
| borrowableAsset: borrowable.address, | ||
| collateralAsset: collateral.address, | ||
| borrowableOracle: borrowableOracle.address, | ||
| collateralOracle: collateralOracle.address, | ||
| irm: irm.address, | ||
| lltv: BigNumber.WAD.div(2), | ||
| }; | ||
| lltv: BigNumber.WAD.div(2).add(1), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes everything about the way tests are wrote in hardhat but it fixes the CI. But I don't know why the CI was broken before, so I just went rewriting it my way and it works... Not good, but it works.