Add return bytes to flashloan callback #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
a team,
Rubilmax,
MerlinEgalite,
Jean-Grimal,
QGarchery,
peyha and
MathisGD
and removed request for
a team
|
Former discussions for reference: |
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Merlin Egalite <44097430+MerlinEgalite@users.noreply.github.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Rubilmax
reviewed
Oct 27, 2023
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
Co-authored-by: Romain Milon <rmilon@gmail.com> Signed-off-by: ultrasecr.eth <241804+ultrasecreth@users.noreply.github.com>
MathisGD
changed the base branch from
cantina-review
to
feat/add-return-bytes-callbacks
MathisGD
merged commit a374650
into
morpho-org:feat/add-return-bytes-callbacks
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds return bytes to the flash loan callback and the flash loan function so a callback user can pass data back to itself without using storage.