Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L02. Unnecessary check #1311

Closed
MerlinEgalite opened this issue Sep 23, 2022 · 0 comments · Fixed by #1313
Closed

L02. Unnecessary check #1311

MerlinEgalite opened this issue Sep 23, 2022 · 0 comments · Fixed by #1313
Assignees
@MerlinEgalite
Labels
👻 aave-v2 👻 aave-v3

Comments

@MerlinEgalite
Copy link
Contributor

In borrowLogic function of EntryPositionsManager contract (in contracts/aave-v2/ and contracts/aave-v3/ folders), the check at line 209 is unnecessary. Consider calling _setBorrowing function without this check since the check consumes extra ~20000 gas at the first call and does not optimize gas consumption for further calls.
@MerlinEgalite MerlinEgalite self-assigned this Sep 23, 2022
MerlinEgalite added a commit that referenced this issue Sep 23, 2022
@MerlinEgalite
⚡️ (#1311) Remove useless check
5507b1e
@MerlinEgalite MerlinEgalite mentioned this issue Sep 23, 2022
Merged
@MerlinEgalite MerlinEgalite linked a pull request Sep 23, 2022 that will close this issue
⚡️ (#1311) Remove useless check #1313
Merged
MerlinEgalite added a commit that referenced this issue Sep 25, 2022
@MerlinEgalite
Merge pull request #1313 from morpho-dao/refactor/useless-check
df43fd5 
⚡️ (#1311) Remove useless check
MerlinEgalite added a commit that referenced this issue Oct 13, 2022
@MerlinEgalite
⚡️ (#1311) Remove useless check
0cd499d
MerlinEgalite added a commit that referenced this issue Oct 14, 2022
@MerlinEgalite
⚡️ (#1311) Remove useless check in supply
9029bae
MerlinEgalite added a commit that referenced this issue Oct 21, 2022
@MerlinEgalite
Merge pull request #1358 from morpho-dao/recover/useless-check
e3ae8ce 
⚡️ (#1311) Remove useless check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MerlinEgalite MerlinEgalite

Labels
👻 aave-v2 👻 aave-v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚡️ (#1311) Remove useless check morpho-org/morpho-optimizers
1 participant
@MerlinEgalite