Add Aave-V2 live tests #1251

Rubilmax · 2022-08-23T14:45:09Z

Pull Request

Issue(s) fixed

Fuzzing on prod cannot be done until Morpho's endpoints are not upgraded on-chain (User.sol now uses all Morpho's endpoints instead of only 1 of each supply/borrow/withdraw/repay)

github-actions · 2022-08-23T14:49:17Z

Morpho-aave-v2 gas impacts (polygon-mainnet)

Generated at commit: 1bc424a26ca616c4722e6af734f0dca32a18f83a, compared to commit: db1470ccf5064f3ebd39c4d1f2b5eaff9a2e0fdf

🧾 Summary

Contract	Method	Avg (+/-)	%
IncentivesVault	setIncentivesTreasuryVault	+1,400 ❌	+28.06%
Morpho	aaveIncentivesController createMarket initialize pool rewardsManager setIncentivesVault setRewardsManager setTreasuryVault	+2 ❌ +31 ❌ +4,523 ❌ -1 ✅ +2 ❌ +7 ❌ +9 ❌ +14 ❌	+0.31% +0.01% +2.01% -0.24% +0.32% +0.03% +0.04% +0.06%
RewardsManagerOnPolygon	initialize	+18 ❌	+0.02%

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
IncentivesVault	572,301 (0)	setIncentivesTreasuryVault	2,583 (0)	0.00%	6,389 (+1,400)	+28.06%	7,192 (+1,400)	+24.17%	8,592 (+2,800)	+48.34%	4 (0)
Morpho	3,436,193 (0)	aaveIncentivesController createMarket initialize pool rewardsManager setIncentivesVault setRewardsManager setTreasuryVault	427 (0) 2,847 (0) 3,663 (0) 406 (0) 404 (0) 2,695 (0) 2,631 (0) 2,673 (0)	0.00% 0.00% 0.00% 0.00% 0.00% 0.00% 0.00% 0.00%	646 (+2) 207,993 (+31) 230,102 (+4,523) 410 (-1) 625 (+2) 23,712 (+7) 21,592 (+9) 23,519 (+14)	+0.31% +0.01% +2.01% -0.24% +0.32% +0.03% +0.04% +0.06%	427 (0) 203,554 (0) 231,146 (+4,500) 406 (0) 404 (0) 23,878 (0) 21,814 (0) 23,856 (0)	0.00% 0.00% +1.99% 0.00% 0.00% 0.00% 0.00% 0.00%	2,427 (0) 229,201 (0) 231,146 (+4,500) 2,406 (0) 2,404 (0) 23,878 (0) 21,814 (0) 23,856 (0)	0.00% 0.00% +1.99% 0.00% 0.00% 0.00% 0.00% 0.00%	2,025 (+63) 1,092 (+45) 218 (+9) 2,436 (+81) 2,002 (+63) 219 (+9) 220 (+9) 221 (+9)
RewardsManagerOnPolygon	1,153,164 (0)	initialize	2,742 (0)	0.00%	92,714 (+18)	+0.02%	93,129 (0)	0.00%	93,129 (0)	0.00%	218 (+9)

github-actions · 2022-08-23T14:49:49Z

Morpho-compound gas impacts (eth-mainnet)

Generated at commit: 1bc424a26ca616c4722e6af734f0dca32a18f83a, compared to commit: db1470ccf5064f3ebd39c4d1f2b5eaff9a2e0fdf

🧾 Summary

Contract	Method	Avg (+/-)	%
Lens	computeLiquidationRepayAmount	-3,872 ✅	-3.56%
Morpho	borrowBalanceInOf createMarket deltas lastPoolIndexes marketParameters	+1 ❌ +1,153 ❌ +11 ❌ +1 ❌ +6 ❌	+0.07% +0.44% +0.49% +0.11% +0.55%

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
Lens	4,798,203 (0)	computeLiquidationRepayAmount	57,311 (0)	0.00%	104,762 (-3,872)	-3.56%	96,652 (0)	0.00%	169,838 (-10)	-0.01%	20 (0)
Morpho	3,267,385 (0)	borrowBalanceInOf createMarket deltas lastPoolIndexes marketParameters	894 (0) 2,714 (0) 1,050 (0) 742 (0) 669 (0)	0.00% 0.00% 0.00% 0.00% 0.00%	1,425 (+1) 260,764 (+1,153) 2,259 (+11) 920 (+1) 1,106 (+6)	+0.07% +0.44% +0.49% +0.11% +0.55%	894 (0) 255,389 (0) 1,050 (0) 742 (0) 669 (0)	0.00% 0.00% 0.00% 0.00% 0.00%	4,894 (0) 307,394 (+7,000) 9,050 (0) 2,742 (0) 2,669 (0)	0.00% +2.33% 0.00% 0.00% 0.00%	519 (-1) 1,500 (0) 205 (-2) 347 (-2) 151 (-2)

github-actions · 2022-08-23T14:50:28Z

Morpho-aave-v2 gas impacts (avalanche-mainnet)

Generated at commit: 1bc424a26ca616c4722e6af734f0dca32a18f83a, compared to commit: db1470ccf5064f3ebd39c4d1f2b5eaff9a2e0fdf

🧾 Summary

Contract	Method	Avg (+/-)	%
IncentivesVault	setIncentivesTreasuryVault	+1,400 ❌	+28.06%
Morpho	aaveIncentivesController createMarket initialize pool rewardsManager setIncentivesVault setRewardsManager setTreasuryVault	+2 ❌ +29 ❌ +4,523 ❌ -1 ✅ +2 ❌ +7 ❌ +9 ❌ +14 ❌	+0.31% +0.01% +2.01% -0.24% +0.32% +0.03% +0.04% +0.06%
RewardsManagerOnMainnetAndAvalanche	initialize	+18 ❌	+0.02%

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
IncentivesVault	572,301 (0)	setIncentivesTreasuryVault	2,583 (0)	0.00%	6,389 (+1,400)	+28.06%	7,192 (+1,400)	+24.17%	8,592 (+2,800)	+48.34%	4 (0)
Morpho	3,436,193 (0)	aaveIncentivesController createMarket initialize pool rewardsManager setIncentivesVault setRewardsManager setTreasuryVault	427 (0) 2,847 (0) 3,663 (0) 406 (0) 404 (0) 2,695 (0) 2,631 (0) 2,673 (0)	0.00% 0.00% 0.00% 0.00% 0.00% 0.00% 0.00% 0.00%	646 (+2) 203,700 (+29) 230,102 (+4,523) 410 (-1) 625 (+2) 23,712 (+7) 21,592 (+9) 23,519 (+14)	+0.31% +0.01% +2.01% -0.24% +0.32% +0.03% +0.04% +0.06%	427 (0) 198,698 (0) 231,146 (+4,500) 406 (0) 404 (0) 23,878 (0) 21,814 (0) 23,856 (0)	0.00% 0.00% +1.99% 0.00% 0.00% 0.00% 0.00% 0.00%	2,427 (0) 227,598 (0) 231,146 (+4,500) 2,406 (0) 2,404 (0) 23,878 (0) 21,814 (0) 23,856 (0)	0.00% 0.00% +1.99% 0.00% 0.00% 0.00% 0.00% 0.00%	2,025 (+63) 1,092 (+45) 218 (+9) 2,436 (+81) 2,002 (+63) 219 (+9) 220 (+9) 221 (+9)
RewardsManagerOnMainnetAndAvalanche	1,133,544 (0)	initialize	2,742 (0)	0.00%	92,714 (+18)	+0.02%	93,129 (0)	0.00%	93,129 (0)	0.00%	218 (+9)

github-actions · 2022-08-23T14:52:29Z

Morpho-aave-v2 gas impacts (eth-mainnet)

Generated at commit: 1bc424a26ca616c4722e6af734f0dca32a18f83a, compared to commit: db1470ccf5064f3ebd39c4d1f2b5eaff9a2e0fdf

🧾 Summary

Contract	Method	Avg (+/-)	%
IncentivesVault	setIncentivesTreasuryVault	+1,400 ❌	+28.06%
Morpho	aaveIncentivesController createMarket initialize pool rewardsManager setIncentivesVault setRewardsManager setTreasuryVault	+2 ❌ +31 ❌ +4,523 ❌ -1 ✅ +2 ❌ +7 ❌ +9 ❌ +14 ❌	+0.31% +0.01% +2.01% -0.24% +0.32% +0.03% +0.04% +0.06%
RewardsManagerOnMainnetAndAvalanche	initialize	+18 ❌	+0.02%

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
IncentivesVault	572,301 (0)	setIncentivesTreasuryVault	2,583 (0)	0.00%	6,389 (+1,400)	+28.06%	7,192 (+1,400)	+24.17%	8,592 (+2,800)	+48.34%	4 (0)
Morpho	3,436,193 (0)	aaveIncentivesController createMarket initialize pool rewardsManager setIncentivesVault setRewardsManager setTreasuryVault	427 (0) 2,847 (0) 3,663 (0) 406 (0) 404 (0) 2,695 (0) 2,631 (0) 2,673 (0)	0.00% 0.00% 0.00% 0.00% 0.00% 0.00% 0.00% 0.00%	646 (+2) 208,107 (+31) 230,102 (+4,523) 410 (-1) 625 (+2) 23,712 (+7) 21,592 (+9) 23,519 (+14)	+0.31% +0.01% +2.01% -0.24% +0.32% +0.03% +0.04% +0.06%	427 (0) 204,995 (0) 231,146 (+4,500) 406 (0) 404 (0) 23,878 (0) 21,814 (0) 23,856 (0)	0.00% 0.00% +1.99% 0.00% 0.00% 0.00% 0.00% 0.00%	2,427 (0) 226,840 (0) 231,146 (+4,500) 2,406 (0) 2,404 (0) 23,878 (0) 21,814 (0) 23,856 (0)	0.00% 0.00% +1.99% 0.00% 0.00% 0.00% 0.00% 0.00%	2,025 (+63) 1,092 (+45) 218 (+9) 2,436 (+81) 2,002 (+63) 219 (+9) 220 (+9) 221 (+9)
RewardsManagerOnMainnetAndAvalanche	1,133,544 (0)	initialize	2,742 (0)	0.00%	92,714 (+18)	+0.02%	93,129 (0)	0.00%	93,129 (0)	0.00%	218 (+9)

MerlinEgalite

Some changes to do but overall LGTM! 🔥

config/eth-mainnet/BaseConfig.sol

test-foundry/prod/aave-v2/setup/TestSetup.sol

test-foundry/prod/aave-v2/TestSupply.t.sol

test-foundry/prod/aave-v2/TestBorrow.t.sol

test-foundry/prod/aave-v2/TestRepay.t.sol

test-foundry/prod/aave-v2/TestSupply.t.sol

Rubilmax marked this pull request as draft August 23, 2022 14:45

github-actions bot added 👻 aave-v2 🧪 testing labels Aug 23, 2022

Base automatically changed from feat/extract-compound-tests to dev August 24, 2022 09:19

Rubilmax force-pushed the feat/extract-aave-tests branch from 0ab48f8 to 328b079 Compare August 25, 2022 12:45

Rubilmax marked this pull request as ready for review August 25, 2022 12:51

MerlinEgalite requested changes Aug 25, 2022

View reviewed changes

pakim249CAL approved these changes Aug 26, 2022

View reviewed changes

MerlinEgalite force-pushed the dev branch from a223210 to 9f19942 Compare August 28, 2022 12:59

Rubilmax added 7 commits August 29, 2022 11:21

🎨 Format lens

213e0d2

Adapt aave-v2 test setup

e9d78ee

Make prod fuzzing tests compile

19ecd19

Make supply tests pass

bac96c2

Make withdraw tests pass

f085810

Make repay tests pass

26ff8e3

Added CRV & stETH

f79142d

Rubilmax force-pushed the feat/extract-aave-tests branch from 328b079 to f79142d Compare August 29, 2022 09:23

Rubilmax added 2 commits August 29, 2022 11:24

Improve comment of \tip

7d64901

Applied changes requests

2ebe033

Rubilmax requested a review from MerlinEgalite August 29, 2022 09:56

MerlinEgalite approved these changes Sep 1, 2022

View reviewed changes

test-foundry/prod/aave-v2/TestSupply.t.sol Show resolved Hide resolved

Rubilmax merged commit aee9436 into dev Sep 2, 2022

Rubilmax deleted the feat/extract-aave-tests branch September 2, 2022 12:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Aave-V2 live tests #1251

Add Aave-V2 live tests #1251

Rubilmax commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022 •

edited

Loading

MerlinEgalite left a comment

Add Aave-V2 live tests #1251

Add Aave-V2 live tests #1251

Conversation

Rubilmax commented Aug 23, 2022 • edited Loading

Pull Request

Issue(s) fixed

github-actions bot commented Aug 23, 2022 • edited Loading

Morpho-aave-v2 gas impacts (polygon-mainnet)

🧾 Summary

github-actions bot commented Aug 23, 2022 • edited Loading

Morpho-compound gas impacts (eth-mainnet)

🧾 Summary

github-actions bot commented Aug 23, 2022 • edited Loading

Morpho-aave-v2 gas impacts (avalanche-mainnet)

🧾 Summary

github-actions bot commented Aug 23, 2022 • edited Loading

Morpho-aave-v2 gas impacts (eth-mainnet)

🧾 Summary

MerlinEgalite left a comment

Choose a reason for hiding this comment

Rubilmax commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022 •

edited

Loading