⬆️ Added foundry-storage-check #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
MathisGD,
julien-devatom,
QGarchery,
MerlinEgalite and
pakim249CAL
MerlinEgalite
approved these changes
Sep 9, 2022
Because it's not yet deployed and it would trigger if we decide to refactor some part of the code. But I can enable it on aave-v3 if we're ok to have a failing CI everytime we change the storage in an unsafe way |
pakim249CAL
approved these changes
Sep 17, 2022
julien-devatom
approved these changes
Sep 23, 2022
|
This PR can be merged but it is not optimal. Some work needs to be done and checked again |
|
A conflict to fix before merging it |
Rubilmax
force-pushed
the
feat/foundry-storage-diff
branch
from
5b5b425
to
efa12cf
Compare
pakim249CAL
approved these changes
Oct 6, 2022
MathisGD
requested changes
Oct 7, 2022
MathisGD
approved these changes
Oct 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request