Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardhat configuration for etherscan verification #1341

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

julien-devatom
Copy link
Collaborator

Pull Request

Issue(s) fixed

This pull request fixes #to-complete

or

This pull request fixes:

  • #to-complete
  • #to-complete
  • ...

Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this PR be based on dev then merged on main @morpho-dao/solidity ?
Or we merged on main then rebase dev on main but I'm not a fan of rebasing dev because of the former issues we've had with rebasing dev...

hardhat.config.ts Outdated Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
@julien-devatom julien-devatom changed the base branch from main to dev October 7, 2022 14:24
@Rubilmax Rubilmax changed the title fix(hardhat): fix hardhat configuration for etherscan verification Fix hardhat configuration for etherscan verification Oct 25, 2022
@Rubilmax Rubilmax merged commit ac99742 into upgrade-0 Oct 25, 2022
@Rubilmax Rubilmax deleted the fix/hardhat-verification branch October 25, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants