Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added maxGasForMatching test for supply #1403

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Added maxGasForMatching test for supply #1403

merged 2 commits into from
Nov 9, 2022

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax commented Nov 8, 2022

Pull Request

@Rubilmax Rubilmax linked an issue Nov 8, 2022 that may be closed by this pull request
Improve Morpho-Compound test coverage #1401
Closed
QGarchery
QGarchery approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few non-blocking suggestions

test-foundry/compound/TestSupply.t.sol Outdated Show resolved Hide resolved
test-foundry/compound/TestSupply.t.sol Outdated Show resolved Hide resolved
test-foundry/compound/TestSupply.t.sol Outdated Show resolved Hide resolved
MerlinEgalite
MerlinEgalite approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rubilmax Rubilmax merged commit 8468142 into upgrade-0 Nov 9, 2022
@Rubilmax Rubilmax deleted the test/max-gas-supply branch November 9, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QGarchery QGarchery QGarchery approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MathisGD MathisGD Awaiting requested review from MathisGD

Assignees
No one assigned
Labels
🧪 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Morpho-Compound test coverage
4 participants
@Rubilmax @QGarchery @MerlinEgalite @pakim249CAL