Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Address in naming #1505

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Remove Address in naming #1505

merged 6 commits into from
Dec 6, 2022

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax commented Dec 1, 2022

Pull Request

Issue(s) fixed

@Rubilmax Rubilmax linked an issue Dec 1, 2022 that may be closed by this pull request
[R&D review] Naming of addresses #1470
Closed
MathisGD
MathisGD reviewed Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a lot of ...Address everywhere in the contracts (not the lens). Maybe we want to get rid of them once and for all

MathisGD
MathisGD reviewed Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still

address tokenBorrowedAddress = borrowMarket.underlyingToken;
        address tokenCollateralAddress = market[_poolTokenCollateral].underlyingToken;

in the aave-v2 ExitPositionsManager

@Rubilmax Rubilmax merged commit f5c6e7f into upgrade-lens-0 Dec 6, 2022
@Rubilmax Rubilmax deleted the fix/lens-address-naming branch December 6, 2022 10:38
@MerlinEgalite
Copy link
Contributor

We should not have changed to Morpho in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MathisGD MathisGD MathisGD approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees
No one assigned
Labels
👻 aave-v2 🟢 compound 🧪 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[R&D review] Naming of addresses
4 participants
@Rubilmax @MerlinEgalite @pakim249CAL @MathisGD