Small fixes #1530
Merged
Small fixes #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
approved these changes
Dec 8, 2022
Rubilmax
reviewed
Dec 8, 2022
| @@ -113,6 +113,7 @@ contract TestMorphoGetters is TestSetup { | |||
| borrower1.supply(cUsdc, to6Decimals(10 ether)); | |||
|
|
|||
| assertEq(morpho.enteredMarkets(address(borrower1), 0), cDai); | |||
| assertEq(IMorpho(address(morpho)).enteredMarkets(address(borrower1), 0), cDai); // test the interface | |||
There was a problem hiding this comment.
Another way of doing this would be to have Morpho inherit its interface, but it's too much work
I don't like adding interface testing because it should be done automatically, some way or another, but it's ok
There was a problem hiding this comment.
We know what CI tool will @Rubilmax code this week end lol
Rubilmax
force-pushed
the
fix/fast-review-fixes
branch
from
e868a0d
to
a7820f6
Compare
Rubilmax
approved these changes
Dec 8, 2022
MathisGD
approved these changes
Dec 9, 2022
pakim249CAL
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation is in commit messages