Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor InterestRatesManager to use InterestRatesModel (Spearbit #22) #1537

Merged
merged 5 commits into from
Dec 19, 2022
Merged

Refactor InterestRatesManager to use InterestRatesModel (Spearbit #22) #1537

merged 5 commits into from
Dec 19, 2022

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax commented Dec 8, 2022 •
edited
Loading

Pull Request

Issue(s) fixed

This pull request fixes #1529

@Rubilmax Rubilmax linked an issue Dec 8, 2022 that may be closed by this pull request
Refactor _computeP2PIndexes to use InterestRateModel's functions (Spearbit #22) #1529
Closed
Base automatically changed from refactor/lens-indexes to upgrade-lens-0 December 9, 2022 08:39
@Rubilmax Rubilmax changed the title Refactor InterestRatesManager to use InterestRatesModel Refactor InterestRatesManager to use InterestRatesModel (Spearbit #22) Dec 9, 2022
MerlinEgalite
MerlinEgalite approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but I still think we could have one single function to compute the P2P indexes -> less code to read and verify

src/compound/libraries/InterestRatesModel.sol Outdated Show resolved Hide resolved
QGarchery
QGarchery approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added a few optional comments

src/aave-v2/InterestRatesManager.sol Outdated Show resolved Hide resolved
src/compound/InterestRatesManager.sol Show resolved Hide resolved
src/compound/InterestRatesManager.sol Outdated Show resolved Hide resolved
@Rubilmax Rubilmax changed the base branch from upgrade-lens-0 to upgrade-morpho-1 December 19, 2022 15:12
@Rubilmax Rubilmax merged commit 231b421 into upgrade-morpho-1 Dec 19, 2022
@Rubilmax Rubilmax deleted the refactor/irm branch December 19, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QGarchery QGarchery QGarchery approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MathisGD MathisGD Awaiting requested review from MathisGD

Assignees
No one assigned
Labels
👻 aave-v2 🟢 compound 🧪 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor _computeP2PIndexes to use InterestRateModel's functions (Spearbit #22)
4 participants
@Rubilmax @QGarchery @MerlinEgalite @pakim249CAL