-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Compound error return (Spearbit #33) #1550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
why don't you kept the previous errors, which were more explicit, and just added the error code ?
-
btw those need to be remove if we keep the new ones
Actually, I think kicking back Compound's errors is more appropriate than using our own custom errors. It is already a given and obvious from a stack trace what function call has an error. I think reverting with a Compound Error provides a good understanding of the error to those that get it. @MathisGD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I agree we must remove the old errors
I'm not sure an integrator not compiling the contracts would have the same level of granularity on a fork (needs to be tested, but not a priority for now). Also, all integrators don't use Which is the reason I stand for granular custom errors (instead of a generic |
3409fe8
to
303288c
Compare
Sorry for the force push. I accidentally commited work intended for another branch, so I reverted. |
Pull Request
Issue(s) fixed
This pull request fixes #1535