[FIX] Format of id in new session | Closing channel if host unreachable #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oul#56 to permit the closing of channel in case of unreachable host Signed-off-by: Valentin Daviot <valentin.daviot@alterway.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @moul
This PR fixes a little problem on the display of newly created bastion session:
Jan 23 09:21:09 foosshportal1 c00617c0c9aa[1422]: 2019/01/23 08:21:09 New connection(bastion): sshUser="barfaz" remote="172.17.0.1:58570" local="172.17.0.3:2222" dbUser=id:'#',email:blabla@foobar.frHere
dbUserappears as the # character from ASCII table, as his id is 35.I changed the format from %q to %d to fix the problem.
Another things that is included is this commit is the fix discussed by @kreanda in #56
It was annoying to multiple people in the company and is imo a QOL improvement.
Do not hesitate to tell me if there's another way to do it :)
Thanks again for the great tool :) 💯