Show 'n/a' in case of missing information to avoid crashing. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
approved these changes
Mar 14, 2018
|
Thank you ! And sorry for the linting and only saw it after doing the PR and you were too reactive for me to have the time to fix it :) |
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR shows 'n/a' in the appropriate field in cases of missing user or host when doing a
session lsoruserkey ls, thus avoiding a crash if listing sessions or userkeys after removing the host or user they reference.Which issue this PR fixes: fixes #53 (
userkey lscrashes) and also somesession lscrashes.Special notes for your reviewer:
Not sure this is the right way to fix this. Maybe userkeys should juste be removed alongside the associated user as there doesn't seem to be a point to keeping them around ? Also maybe database constraints should be added to avoid breaking relations ? Don't hesitate to tell me and I will look into modifying the PR accordingly.