Add optional django-silk #1809
Closed
Add optional django-silk #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fx-relay-demo canceled.
|
✅ Deploy Preview for fx-relay-demo canceled.
|
Silk is a live profiling and inspection tool for Django, suitable for local development. It is disabled when DEBUG=False. It is also disabled when running tests, since it adds database queries for writing profile data to the database.
groovecoder
reviewed
Apr 21, 2022
Comment on lines
+26
to
+29
| # This needs to be before markus, which imports pytest | ||
| IN_PYTEST = "pytest" in sys.modules | ||
| if IN_PYTEST: | ||
| assert 1==2 |
There was a problem hiding this comment.
question: I don't understand why we're doing this? This looks like it's just going to fail everything when we're "in pytest"?
There was a problem hiding this comment.
That is because I didn't remove my test code from the PR 😅
Also, I should move this branch to the main repo so CI will run the tests.
|
Replaced by PR #1829. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silk is a live profiling and inspection tool for Django, suitable for local development. It is disabled when
DEBUG=False. It is also disabled when running tests, since it adds database queries for writing profile data to the database, using the mechanism suggested at pytest-dev/pytest#9502.This is based on https://gist.github.com/groovecoder/5d2963d753cdfa690507a415b565dbaa
I'm not convinced we should add it by default, but if you want to use it, this makes it a lot easier.