Re-factor how a pending #switchAnnotationEditorModeTimeoutId is cancelled when closing the document
#18850
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…celled when closing the document The likelihood of the document being closed while the `#switchAnnotationEditorModeTimeoutId` is pending is obviously very low, but it's still a situation we need to account for to prevent errors. However it seems a bit unfortunate that we have to remember to manually invoke the cleanup-method, and instead we can let a pending timeout run and just check that the relevant `AbortSignal` hasn't been aborted before updating editor-state.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/39d96046b9135bd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b19bbb89b204fc0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/39d96046b9135bd/output.txt Total script time: 9.82 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b19bbb89b204fc0/output.txt Total script time: 20.33 mins
|
|
On second thought I suppose that potentially leaving a timeout running, even for a very short while, could affect tests negatively. |
Snuffleupagus
deleted the
resetView-rm-cleanupSwitchAnnotationEditorMode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The likelihood of the document being closed while the
#switchAnnotationEditorModeTimeoutIdis pending is obviously very low, but it's still a situation we need to account for to prevent errors.However it seems a bit unfortunate that we have to remember to manually invoke the cleanup-method, and instead we can let a pending timeout run and just check that the relevant
AbortSignalhasn't been aborted before updating editor-state.