Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLPrograms: Fix fogExp2 parameter. #27430

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

vanruesc
Copy link
Contributor

@vanruesc vanruesc commented Dec 23, 2023

Description

The fogExp2 parameter returned by WebGLPrograms.getParameters can currently be null if fog is null which seems to be a mistake. This PR fixes this by converting fog to a boolean.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
670.7 kB (166.7 kB) 670.7 kB (166.7 kB) +2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
451.5 kB (109.7 kB) 451.5 kB (109.7 kB) +2 B

@Mugen87 Mugen87 added this to the r161 milestone Dec 24, 2023
@Mugen87 Mugen87 merged commit 3c8d309 into mrdoob:dev Dec 24, 2023
12 checks passed
@Mugen87 Mugen87 changed the title WebGLPrograms: Fix fogExp2 WebGLPrograms: Fix fogExp2 parameter. Dec 24, 2023
vanruesc added a commit to vanruesc/three-ts-types that referenced this pull request Dec 26, 2023
Methuselah96 added a commit to three-types/three-ts-types that referenced this pull request Jan 9, 2024
mrdoob/three.js#27430

Co-authored-by: Nathan Bierema <nbierema@gmail.com>
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants