Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: Fix active not being accounted for, bounding box functions returning incorrect fields #27484

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

gkjohnson
Copy link
Collaborator

Related issue: https://discourse.threejs.org/t/when-batchedmesh-uses-deletegeometry-all-models-will-disappear-together

Description

  • Fixes the BatchedMesh bounding volume functions returning "this" instead of "null"
  • Fixes BatchedMesh not accounting for "active" in the sort, frustum culling functions

@gkjohnson gkjohnson added this to the r161 milestone Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
671 kB (166.8 kB) 671 kB (166.8 kB) +27 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
451.9 kB (109.8 kB) 451.9 kB (109.8 kB) +0 B

@gkjohnson gkjohnson merged commit 17d8eee into mrdoob:dev Jan 2, 2024
12 checks passed
@gkjohnson gkjohnson deleted the batch-mesh-fix branch January 2, 2024 09:44
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants