Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferGeometryUtils.mergeAttributes: Add support for interleaved buffers #27591

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Jan 19, 2024

Related issue: --

Description

Adjusts the mergeAttributes to fall back to individual element item copying when interleaved attribute buffers are used. Relies on getComponent from #27590.

@gkjohnson gkjohnson added this to the r161 milestone Jan 19, 2024
@gkjohnson gkjohnson marked this pull request as ready for review January 19, 2024 10:01
@gkjohnson gkjohnson requested review from WestLangley and Mugen87 and removed request for WestLangley January 19, 2024 10:03
@gkjohnson gkjohnson merged commit 687df5c into mrdoob:dev Jan 19, 2024
11 checks passed
@gkjohnson gkjohnson deleted the merge-interleaved-attrs branch January 19, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants