Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Better skinning performance #27753

Merged
merged 3 commits into from
Feb 17, 2024
Merged

WebGPURenderer: Better skinning performance #27753

merged 3 commits into from
Feb 17, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Feb 16, 2024

Related issue: Closes #27741

Description

It was necessary to create referenceBuffer, SkinningNode will now be able to share the same shader with other SkinnedMesh.

@sunag sunag added this to the r162 milestone Feb 16, 2024
@mrdoob
Copy link
Owner

mrdoob commented Feb 16, 2024

/ping @0b5vr

@sunag sunag marked this pull request as ready for review February 17, 2024 00:19
@sunag sunag merged commit 319e314 into mrdoob:dev Feb 17, 2024
11 checks passed
@sunag sunag deleted the dev-skin branch February 17, 2024 01:39
@0b5vr
Copy link
Collaborator

0b5vr commented Feb 19, 2024

Epic!! Thank you! I will check if this improves the performance.

@0b5vr
Copy link
Collaborator

0b5vr commented Feb 20, 2024

I just tried the dev (af2b8944) with an implementation that aligns skeleton bones with the same count, and it seems it's working very well, loading models that previously took 8-10s in 2-3s. Thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPURenderer, NodeMaterial: same variant between different Skeletons?
3 participants