Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Remove redundant clear in transmission pass. #28447

Merged
merged 2 commits into from
May 21, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 21, 2024

Related issue: #28434

Description

see #28434 (comment)

After introducing the call of WebGLBackground.render() in the transmission pass, the existing call of clear() is now redundant when _renderBackground is true.

@Mugen87 Mugen87 added this to the r165 milestone May 21, 2024
Copy link

github-actions bot commented May 21, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
679.1 kB (168.3 kB) 679.1 kB (168.3 kB) -1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
457.1 kB (110.3 kB) 457.1 kB (110.4 kB) -1 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant