Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:translation import error #28619

Merged
merged 1 commit into from
Jun 11, 2024
Merged

docs:translation import error #28619

merged 1 commit into from
Jun 11, 2024

Conversation

mmjinglin163
Copy link
Contributor

The translation of import is incorrect

@Mugen87 Mugen87 added this to the r166 milestone Jun 11, 2024
@@ -15,7 +15,7 @@ <h1>拖放控制器([name])</h1>
该类被用于提供一个拖放交互。
</p>

<h2>进口</h2>
<h2>引入</h2>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<h2>进口</h2> is used in all Chinese documentation pages in docs/examples/zh. If you want to change the syntax, please do it for all of them.

Copy link
Collaborator

@Mugen87 Mugen87 Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ycw Is the new translation okay? According to Google translate, it seems the existing one is more correct.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure the new translation is more correct. 进口 is often used to describe the importation of goods and In Chinese it is more accurate to say 引入 for code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term Import in this context is 导入. Refs: MDN, Blender, Godot, Editor

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In this case, it would be good if the PR updates all doc pages with the new notation 引入.

@Mugen87 Mugen87 modified the milestone: r166 Jun 11, 2024
@Mugen87 Mugen87 merged commit 8a1bacf into mrdoob:dev Jun 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants