Revert "TSL: Added type conversions to WGSLNodeFunction and fleshed…
#28659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… out precision. (mrdoob#28577)" This reverts commit e37cf82.
|
I see what you mean. In the old (now reverted version), types are vec3f, vec2f, vec2f, texture_2d, sampler, float x10. The newer code generated types of vec3f, vec2f, vec2f, texture_2d(!), sampler, float x10. I suppose there are a few solutions. We could just add edge cases to the type lib for all the types that should have their filtered (texture_2d, texture_2d_array, texture_3d, etc), but that might add too many checks. I'll look and see if there's something more efficient that can be done within the FunctionNode, and check it against each of the existing WGSL forward samples first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28577
Description
This broken that PR and example, because the approach did not filter
<type>of the textures.I think we can reimplement again after this fix.